Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid unknown web.Application attributes #3542

Merged
merged 3 commits into from
Jan 15, 2019
Merged

Conversation

asvetlov
Copy link
Member

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #3542 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3542      +/-   ##
=========================================
+ Coverage   97.88%   97.9%   +0.02%     
=========================================
  Files          43      43              
  Lines        8585    8752     +167     
  Branches     1388    1450      +62     
=========================================
+ Hits         8403    8569     +166     
  Misses         75      75              
- Partials      107     108       +1
Impacted Files Coverage Δ
aiohttp/web_app.py 98.88% <100%> (-0.01%) ⬇️
aiohttp/helpers.py 97.53% <0%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f590bfd...f60827c. Read the comment docs.

Copy link
Member

@kxepal kxepal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CHANGES/3542.removal Outdated Show resolved Hide resolved
@asvetlov asvetlov merged commit c3bbbf1 into master Jan 15, 2019
@asvetlov asvetlov deleted the forbid-wild-app-attrs branch January 15, 2019 09:16
@lock
Copy link

lock bot commented Jan 15, 2020

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Jan 15, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 15, 2020
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants