Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirects with changing cookie values #3576

Merged
merged 4 commits into from Feb 26, 2019

Conversation

@amelchio
Copy link
Contributor

commented Jan 23, 2019

What do these changes do?

Fix an issue where cookies would sometimes not be set during a redirect.

When looping due to a redirect, the cookies variable from the previous loop would clobber the cookies argument introduced in #3396.

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@amelchio amelchio requested review from asvetlov and webknjaz as code owners Jan 23, 2019

amelchio added 3 commits Jan 23, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Feb 6, 2019

Codecov Report

Merging #3576 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3576   +/-   ##
======================================
  Coverage    97.9%   97.9%           
======================================
  Files          43      43           
  Lines        8556    8556           
  Branches     1376    1376           
======================================
  Hits         8377    8377           
  Misses         74      74           
  Partials      105     105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36331ce...02ea86e. Read the comment docs.

@amelchio

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2019

I apologize for missing some lint, I think there were some general build issues that made it hard for me to see that some of the breakage was caused by myself. Anyway, all fixed now.

@amelchio

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

@asvetlov Sorry to disturb. You approved #3396, is there more I can do to get the fix in this PR merged?

@asvetlov

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

Sorry, I'm very busy this month.
The PR is good.
Thank you for patience.

@asvetlov asvetlov merged commit 398b5ba into aio-libs:master Feb 26, 2019

4 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codecov/patch Coverage not affected when comparing 36331ce...02ea86e
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
asvetlov added a commit that referenced this pull request Feb 26, 2019
[3.5] Fix redirects with changing cookie values (#3576)
(cherry picked from commit 398b5ba)

Co-authored-by: Anders Melchiorsen <amelchio@nogoto.net>
asvetlov added a commit that referenced this pull request May 8, 2019
[3.5] Fix redirects with changing cookie values (#3576) (#3626)
(cherry picked from commit 398b5ba)

Co-authored-by: Anders Melchiorsen <amelchio@nogoto.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.