Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Use sanitized URL as Location header in redirects #3614

Merged
merged 1 commit into from Feb 17, 2019

Conversation

@m-burst
Copy link
Contributor

commented Feb 17, 2019

Backport of #3613 for the 3.5 branch

@m-burst m-burst requested review from asvetlov and webknjaz as code owners Feb 17, 2019

@webknjaz webknjaz merged commit 74e3d74 into aio-libs:3.5 Feb 17, 2019

1 of 3 checks passed

Travis CI - Pull Request Build Errored
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
WIP Ready for review
Details
@m-burst m-burst referenced this pull request Feb 17, 2019
4 of 5 tasks complete

@m-burst m-burst deleted the m-burst:fix-redirect-url-3.5 branch Feb 17, 2019

@m-burst

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2019

@webknjaz Looking at it again, I think this might be seen as breaking for some of the users who expect the location property on an HTTPFound object to be a string if they passed a string (and also I broke a test and made the mistake of not running them locally before opening the PR). Should I fix this in a follow-up PR?

@webknjaz

This comment has been minimized.

Copy link
Member

commented Feb 17, 2019

Odd... CI was green. I'm not sure what you mean but PR is welcome and we can go through a review process there :)

@m-burst

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2019

@webknjaz CI probably didn't fully run because the PR was merged very quickly.
Please see the fix in #3615.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.