Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Resolvers description in Client reference docs #3642

Merged
merged 1 commit into from
May 10, 2019

Conversation

JanBednarik
Copy link
Contributor

@JanBednarik JanBednarik commented Mar 7, 2019

What do these changes do?

From the docs it seems like asynchronous Resolver is used by default when aiodns is installed. It's not true since: 9fbb7d7 This change should make it clear.

Are there changes in behavior for the user?

No.

Related issue number

No.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #3642 into master will decrease coverage by 3.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3642     +/-   ##
=========================================
- Coverage    97.9%   94.41%   -3.5%     
=========================================
  Files          43       43             
  Lines        8556     8555      -1     
  Branches     1376     1375      -1     
=========================================
- Hits         8377     8077    -300     
- Misses         74      359    +285     
- Partials      105      119     +14
Impacted Files Coverage Δ
aiohttp/worker.py 6.55% <0%> (-90.99%) ⬇️
aiohttp/resolver.py 46.55% <0%> (-53.45%) ⬇️
aiohttp/web_fileresponse.py 66.66% <0%> (-29.89%) ⬇️
aiohttp/tcp_helpers.py 63.33% <0%> (-26.67%) ⬇️
aiohttp/typedefs.py 91.3% <0%> (-8.7%) ⬇️
aiohttp/pytest_plugin.py 89.79% <0%> (-7.49%) ⬇️
aiohttp/locks.py 92.85% <0%> (-7.15%) ⬇️
aiohttp/web_runner.py 91.7% <0%> (-6.22%) ⬇️
aiohttp/__init__.py 94.44% <0%> (-5.56%) ⬇️
aiohttp/http_parser.py 93.11% <0%> (-4.82%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f489a92...40aad74. Read the comment docs.

@asvetlov asvetlov merged commit 4b9adf7 into aio-libs:master May 10, 2019
@asvetlov
Copy link
Member

Thanks

@lock lock bot added the outdated label May 20, 2020
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants