-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix decoding base64 chunk for BodyPartReader #3867
Conversation
|
Thanks! |
(cherry picked from commit aeb01ce) Co-authored-by: Yevhenii Hyzyla <hyzyla@gmail.com>
|
Think a backport got screwed up here... |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply aeb01ce on top of patchback/backports/3.11/aeb01ce3bda7497d7cc6c434ac6806aca291e273/pr-3867 Backporting merged PR #3867 into master
🤖 @patchback |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply aeb01ce on top of patchback/backports/3.10/aeb01ce3bda7497d7cc6c434ac6806aca291e273/pr-3867 Backporting merged PR #3867 into master
🤖 @patchback |
(cherry picked from commit aeb01ce)
(cherry picked from commit aeb01ce)
What do these changes do?
Those changes add the additional reading of few bytes in
BodyPartReader.read_chunkif the size of the chunk is not valid for base64 decoding.Are there changes in behavior for the user?
Yes, because if someone will try to use
read_chunkfor the body that has transfer encoding equal to base64, can receive more than expected bytes.Related issue number
#3843
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.