Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed type annotation in method add_view in UrlDispatcher #3880

Merged

Conversation

@ilyachch
Copy link
Contributor

commented Jul 1, 2019

What do these changes do?

Fixes type annotation in method add_view in UrlDispatcher
If user passes View subclass to add_view method, type checkers shows, the expected type AbstractView, not provided class.

Are there changes in behavior for the user?

No

Checklist

  • I think the code is well written
  • Unit tests for the changes exist (No new functions are added or changed, so it covered with existing tests)
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
Ilya Chichak added 2 commits Jul 1, 2019

@ilyachch ilyachch requested review from asvetlov and webknjaz as code owners Jul 1, 2019

@asvetlov
Copy link
Member

left a comment

Looks good but please add a changelog entry into ./CHANGES folder.

Ilya Chichak
@codecov-io

This comment has been minimized.

Copy link

commented Jul 3, 2019

Codecov Report

Merging #3880 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3880      +/-   ##
==========================================
- Coverage   97.96%   97.85%   -0.11%     
==========================================
  Files          43       43              
  Lines        8590     8590              
  Branches     1373     1373              
==========================================
- Hits         8415     8406       -9     
- Misses         71       78       +7     
- Partials      104      106       +2
Impacted Files Coverage Δ
aiohttp/web_urldispatcher.py 99.25% <100%> (ø) ⬆️
aiohttp/locks.py 92.85% <0%> (-7.15%) ⬇️
aiohttp/web_fileresponse.py 96.55% <0%> (-1.15%) ⬇️
aiohttp/worker.py 96.72% <0%> (-0.82%) ⬇️
aiohttp/streams.py 97.92% <0%> (-0.52%) ⬇️
aiohttp/helpers.py 96.96% <0%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e0177a...d5492a6. Read the comment docs.

@ilyachch

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

@asvetlov done

@asvetlov asvetlov merged commit 049101b into aio-libs:master Jul 5, 2019

5 of 6 checks passed

LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codecov/patch 100% of diff hit (target 97.96%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@asvetlov

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

Thanks!

asvetlov added a commit that referenced this pull request Jul 5, 2019
[3.5] fixed type annotation in method add_view in UrlDispatcher (#3880)
(cherry picked from commit 049101b)

Co-authored-by: Ilya Chichak <ilyachch@gmail.com>
asvetlov added a commit that referenced this pull request Jul 5, 2019
[3.5] fixed type annotation in method add_view in UrlDispatcher (#3880)…
… (#3887)

(cherry picked from commit 049101b)

Co-authored-by: Ilya Chichak <ilyachch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.