Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid inheritance from ClientSession and Application #3933

Merged
merged 5 commits into from
Jul 24, 2019

Conversation

asvetlov
Copy link
Member

No description provided.

@asvetlov asvetlov requested a review from webknjaz as a code owner July 23, 2019 20:27
@codecov-io
Copy link

Codecov Report

Merging #3933 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3933      +/-   ##
==========================================
+ Coverage   97.71%   97.72%   +0.01%     
==========================================
  Files          43       43              
  Lines        8795     8799       +4     
  Branches     1381     1383       +2     
==========================================
+ Hits         8594     8599       +5     
  Misses         86       86              
+ Partials      115      114       -1
Impacted Files Coverage Δ
aiohttp/helpers.py 97.53% <100%> (+0.01%) ⬆️
aiohttp/web_app.py 99.17% <100%> (ø) ⬆️
aiohttp/http_parser.py 97.09% <0%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39a26f...15e5cbb. Read the comment docs.

@asvetlov asvetlov merged commit df77ea7 into master Jul 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the forbid-inheritance branch July 24, 2019 07:51
@kxepal
Copy link
Member

kxepal commented Jul 24, 2019

Finally!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants