Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid changing frozen app properties #3948

Merged
merged 2 commits into from
Jul 27, 2019
Merged

Conversation

asvetlov
Copy link
Member

The following code was raising deprecation and forbidden now.

app.freeze()
app['foo'] = 'bar'

@kxepal
Copy link
Member

kxepal commented Jul 26, 2019

What is the recommendation to do in this case: there is an app property, but it only could be initialized in async-way, so it has to be put in onstartup signal handler where app is frozen? Do some mutable placeholders?

@codecov-io
Copy link

Codecov Report

Merging #3948 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3948      +/-   ##
==========================================
+ Coverage   97.69%   97.91%   +0.22%     
==========================================
  Files          43       43              
  Lines        8761     9158     +397     
  Branches     1377     1546     +169     
==========================================
+ Hits         8559     8967     +408     
+ Misses         88       84       -4     
+ Partials      114      107       -7
Impacted Files Coverage Δ
aiohttp/web_app.py 97.28% <100%> (ø) ⬆️
aiohttp/web_fileresponse.py 96.55% <0%> (-1.15%) ⬇️
aiohttp/helpers.py 97.53% <0%> (ø) ⬆️
aiohttp/web_protocol.py 92.35% <0%> (+0.61%) ⬆️
aiohttp/client_reqrep.py 97.67% <0%> (+0.68%) ⬆️
aiohttp/web_response.py 99.13% <0%> (+1.46%) ⬆️
aiohttp/web_request.py 98% <0%> (+1.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7642e4d...751adb8. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #3948 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3948      +/-   ##
==========================================
+ Coverage   97.69%   97.91%   +0.22%     
==========================================
  Files          43       43              
  Lines        8761     9158     +397     
  Branches     1377     1546     +169     
==========================================
+ Hits         8559     8967     +408     
+ Misses         88       84       -4     
+ Partials      114      107       -7
Impacted Files Coverage Δ
aiohttp/web_app.py 97.28% <100%> (ø) ⬆️
aiohttp/web_fileresponse.py 96.55% <0%> (-1.15%) ⬇️
aiohttp/helpers.py 97.53% <0%> (ø) ⬆️
aiohttp/web_protocol.py 92.35% <0%> (+0.61%) ⬆️
aiohttp/client_reqrep.py 97.67% <0%> (+0.68%) ⬆️
aiohttp/web_response.py 99.13% <0%> (+1.46%) ⬆️
aiohttp/web_request.py 98% <0%> (+1.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7642e4d...751adb8. Read the comment docs.

@asvetlov asvetlov merged commit b5b3040 into master Jul 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the forbid-changing-frozen-app branch July 27, 2019 09:02
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants