Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hint istr keys allowed in LooseHeaders #3976

Merged
merged 3 commits into from Aug 15, 2019

Conversation

@scop
Copy link
Contributor

commented Aug 11, 2019

What do these changes do?

Allows one to use e.g. {hdrs.SOMETHING: ...} as headers per type checks.

Are there changes in behavior for the user?

No.

Related issue number

I don't think so.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@scop scop requested a review from asvetlov as a code owner Aug 11, 2019

Type hint istr keys allowed in LooseHeaders
So one can use e.g. {hdrs.SOMETHING: ...} as headers.
@codecov-io

This comment has been minimized.

Copy link

commented Aug 11, 2019

Codecov Report

Merging #3976 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3976      +/-   ##
==========================================
- Coverage   97.77%   97.75%   -0.03%     
==========================================
  Files          43       43              
  Lines        8763     8763              
  Branches     1375     1375              
==========================================
- Hits         8568     8566       -2     
- Misses         83       84       +1     
- Partials      112      113       +1
Impacted Files Coverage Δ
aiohttp/typedefs.py 100% <100%> (ø) ⬆️
aiohttp/web_fileresponse.py 96.59% <0%> (-1.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38a1ec4...c936b32. Read the comment docs.

@asvetlov
Copy link
Member

left a comment

The PR idea is correct.

To make it merged please:

  1. Run make isort to reorder imports and get Travis CI passed.
  2. Write a record in CHANGES folder.
@scop

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

Done. make isort modifies a lot of files not touched by this PR, so I just extracted and added the aiohttp/typedefs.py part of it here.

@asvetlov
Copy link
Member

left a comment

LGTM

@asvetlov asvetlov merged commit ec5aee7 into aio-libs:master Aug 15, 2019

6 of 7 checks passed

LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
Timeline protection Timeline protection: Good to go
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codecov/patch 100% of diff hit (target 97.77%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@asvetlov

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

Thanks!

asvetlov added a commit that referenced this pull request Aug 15, 2019
[3.6] Type hint istr keys allowed in LooseHeaders (#3976)
(cherry picked from commit ec5aee7)

Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>

@scop scop deleted the scop:looseheaders-istr branch Aug 15, 2019

asvetlov added a commit that referenced this pull request Aug 15, 2019
[3.6] Type hint istr keys allowed in LooseHeaders (#3976) (#3981)
(cherry picked from commit ec5aee7)

Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.