Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept non-GET request for starting websocket handshake on server side #3980

Merged
merged 2 commits into from Aug 15, 2019

Conversation

@asvetlov
Copy link
Member

commented Aug 15, 2019

We allow this for client-side starting from aiohttp 3.5

@codecov-io

This comment has been minimized.

Copy link

commented Aug 15, 2019

Codecov Report

Merging #3980 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3980      +/-   ##
==========================================
- Coverage   97.77%   97.75%   -0.03%     
==========================================
  Files          43       43              
  Lines        8763     8763              
  Branches     1375     1375              
==========================================
- Hits         8568     8566       -2     
- Misses         83       84       +1     
- Partials      112      113       +1
Impacted Files Coverage Δ
aiohttp/web_fileresponse.py 96.59% <0%> (-1.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a80c8...379ffb2. Read the comment docs.

@asvetlov asvetlov merged commit 8f619a5 into master Aug 15, 2019

8 of 10 checks passed

actions-experiment-filter-webknjaz actions-experiment-filter-webknjaz
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
Timeline protection Timeline protection: Good to go
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codecov/patch Coverage not affected when comparing c5a80c8...379ffb2
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@asvetlov asvetlov deleted the relax-ws-handshake-method branch Aug 15, 2019

asvetlov added a commit that referenced this pull request Aug 15, 2019
[3.6] Accept non-GET request for starting websocket handshake on serv…
…er side (#3980)

(cherry picked from commit 8f619a5)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
asvetlov added a commit that referenced this pull request Aug 16, 2019
[3.6] Accept non-GET request for starting websocket handshake on serv…
…er side (#3980) (#3982)

(cherry picked from commit 8f619a5)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.