Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct names in tests #3994

Merged
merged 3 commits into from
Aug 19, 2019
Merged

correct names in tests #3994

merged 3 commits into from
Aug 19, 2019

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Aug 19, 2019

What do these changes do?

correct the names of some fuctions in tests/test_client_functional.py.

Are there changes in behavior for the user?

no

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes NA
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 19, 2019
Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go ahead, merge when ready

@samuelcolvin samuelcolvin marked this pull request as ready for review August 19, 2019 12:31
@samuelcolvin samuelcolvin merged commit 9e0fa0a into aio-libs:master Aug 19, 2019
@samuelcolvin samuelcolvin deleted the tweak-client-tests branch August 19, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants