Use Iterable hint instead of Sequence #4125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that the `FrozenList` type hint is `Union[List[_T], Iterable[_T]]` the Application middleware type should not restrict to `Sequence` and support all `Iterable` types.
Codecov Report
@@ Coverage Diff @@
## master #4125 +/- ##
=======================================
Coverage 97.33% 97.33%
=======================================
Files 43 43
Lines 8849 8849
Branches 1381 1381
=======================================
Hits 8613 8613
Misses 114 114
Partials 122 122
Continue to review full report at Codecov.
|
asvetlov
requested changes
Oct 2, 2019
stj
force-pushed
the
change_application_middleware_typehint
branch
from
72e3142 to
cd50afa
Compare
psf-chronographer
bot
added
the
bot:chronographer:provided
|
Done. |
asvetlov
approved these changes
Oct 2, 2019
|
Thanks! |
asvetlov
pushed a commit
that referenced
this pull request
Oct 2, 2019
Given that the `FrozenList` type hint is `Union[List[_T], Iterable[_T]]` the Application middleware type should not restrict to `Sequence` and support all `Iterable` types.. (cherry picked from commit 8475395) Co-authored-by: Stefan T <66305+stj@users.noreply.github.com>
asvetlov
added a commit
that referenced
this pull request
Oct 3, 2019
Given that the `FrozenList` type hint is `Union[List[_T], Iterable[_T]]` the Application middleware type should not restrict to `Sequence` and support all `Iterable` types.. (cherry picked from commit 8475395) Co-authored-by: Stefan T <66305+stj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the
FrozenListtype hint isUnion[List[_T], Iterable[_T]]the Application middleware type should not restrict to
Sequenceandsupport all
Iterabletypes.What do these changes do?
In my application I pass a generator type as the middleware argument to create a web.Application. mypy complains that it is not a
Sequencetype as hinted in the class. I feel the Sequence hint isto restrictive and an Iterable is the better choice.
Are there changes in behavior for the user?
No.
Related issue number
None
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.