-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support addition of routes when handler is wrapped by functools.partial() #4302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pped by functools.partial()
Codecov Report
@@ Coverage Diff @@
## master #4302 +/- ##
==========================================
- Coverage 97.58% 97.55% -0.04%
==========================================
Files 43 43
Lines 8857 8862 +5
Branches 1387 1389 +2
==========================================
+ Hits 8643 8645 +2
- Misses 91 93 +2
- Partials 123 124 +1
Continue to review full report at Codecov.
|
asvetlov
requested changes
Oct 29, 2019
|
Fixed the pypy and merged master |
asvetlov
approved these changes
Oct 29, 2019
|
thanks! |
|
Also fixes #3252 |
|
Thanks @nicktimko |
asvetlov
pushed a commit
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In aiohttp v4 a new check was added to make sure that route handlers are coroutines.
Python < v3.8 will return False for asyncio.iscoroutine(functools.partial(async_function)).
The change will iterate the wrapped function to make sure its async
Are there changes in behavior for the user?
No
Related issue number
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.