-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement binding to IPv6 addresses in the pytest server fixture. #4650
Merged
webknjaz
merged 5 commits into
aio-libs:master
from
tan01:user/tan01/bugfix/ipv6_test_utils_server
Mar 22, 2020
Merged
Implement binding to IPv6 addresses in the pytest server fixture. #4650
webknjaz
merged 5 commits into
aio-libs:master
from
tan01:user/tan01/bugfix/ipv6_test_utils_server
Mar 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
webknjaz
reviewed
Mar 20, 2020
|
Plz go through the checklist/add a change fragment. |
This change allows TestServer to be instantiated with IPv6 hostnames. Previously, the TestServer would open an IPv4 family socket regardless of hostname, causing an error to be raised upon starting the server. The BaseTestServer now parses the hostname and create an IPv4 or IPv6 socket based on the hostname.
c0120b2 to
525f369
Compare
tan01
commented
Mar 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through the checklist, added change fragment/modified contributors.
webknjaz
reviewed
Mar 20, 2020
webknjaz
reviewed
Mar 20, 2020
webknjaz
reviewed
Mar 20, 2020
webknjaz
reviewed
Mar 20, 2020
Defaults to AF_INET.
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
webknjaz
approved these changes
Mar 22, 2020
asvetlov
pushed a commit
that referenced
this pull request
Oct 16, 2020
PR #4650 by @tan01 This change allows TestServer to be instantiated with IPv6 hostnames. Previously, the TestServer would open an IPv4 family socket regardless of hostname, causing an error to be raised upon starting the server. The BaseTestServer now parses the hostname and create an IPv4 or IPv6 socket based on the hostname. Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Mic92
pushed a commit
to Mic92/aiohttp
that referenced
this pull request
Sep 11, 2024
PR aio-libs#4650 by @tan01 This change allows TestServer to be instantiated with IPv6 hostnames. Previously, the TestServer would open an IPv4 family socket regardless of hostname, causing an error to be raised upon starting the server. The BaseTestServer now parses the hostname and create an IPv4 or IPv6 socket based on the hostname. Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
5 tasks
Mic92
pushed a commit
to Mic92/aiohttp
that referenced
this pull request
Sep 11, 2024
PR aio-libs#4650 by @tan01 This change allows TestServer to be instantiated with IPv6 hostnames. Previously, the TestServer would open an IPv4 family socket regardless of hostname, causing an error to be raised upon starting the server. The BaseTestServer now parses the hostname and create an IPv4 or IPv6 socket based on the hostname. Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Mic92
pushed a commit
to Mic92/aiohttp
that referenced
this pull request
Sep 11, 2024
PR aio-libs#4650 by @tan01 This change allows TestServer to be instantiated with IPv6 hostnames. Previously, the TestServer would open an IPv4 family socket regardless of hostname, causing an error to be raised upon starting the server. The BaseTestServer now parses the hostname and create an IPv4 or IPv6 socket based on the hostname. Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This change allows TestServer to be instantiated with IPv6 hostnames.
Previously, the TestServer would open an IPv4 family socket regardless
of hostname, causing an error to be raised upon starting the server.
The BaseTestServer now parses the hostname and create an IPv4 or
IPv6 socket based on the hostname.
Are there changes in behavior for the user?
Creating a TestServer from test_utils.py with an IPv6 hostname ('::1') no longer throws
Related issue number
None
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.