Introduce fixture for test client class redefinition #4706
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: oleg.hoefling oleg.hoefling@gmail.com
What do these changes do?
A new fixture named
aiohttp_client_clsis added that serves asTestClientfactory for theaiohttp_clientfixture.When writing tests against
aiohttpapps, we often need to extend theTestClientwith methods that hide the low-level boilerplate, e.g.To replace the
TestClientwith the custom client impl, we have to copy theaiohttp_clientfixture out as there's no safe way to inject theGraphqlClientclass.The changes in this PR offer a possibility to pass a custom test client impl. Example:
A more common example could be providing a
login()/logout()method pair, similar to Django/Flask's test clients.Are there changes in behavior for the user?
Nothing will change for existing test suites.
Checklist
CONTRIBUTORS.txtCHANGESfolder