Improve performance of transport in-use list. #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2015 19:58
Connector keeps its in-use transport in a dictionary `_acquired` mapping hostnames/ports/ssl to lists of transports. Applications that open many connections to the same remote web service end up having a single-item dictionary with a long list as value. Whenever a transport is released, the item is `.remove()`d from the list that has a O(n) complexity. Also `.append()` on a python list can have O(n) complexity. In this patch we use a set instead, so `.remove()` and `add()` have O(1)
fafhrd91
added a commit
that referenced
this pull request
Aug 26, 2015
Improve performance of transport in-use list.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connector keeps its in-use transport in a dictionary
_acquiredmapping hostnames/ports/ssl to lists of transports.
Applications that open many connections to the same remote web service
end up having a single-item dictionary with a long list as value.
Whenever a transport is released, the item is
.remove()d from the listthat has a O(n) complexity. Also
.append()on a python list can haveO(n) complexity.
In this patch we use a set instead, so
.remove()andadd()have O(1)