Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip default headers #486

Merged
merged 11 commits into from Sep 3, 2015
Merged

Skip default headers #486

merged 11 commits into from Sep 3, 2015

Conversation

@asvetlov
Copy link
Member

@asvetlov asvetlov commented Sep 2, 2015

Fix for #457

@asvetlov asvetlov added this to the 0.18 milestone Sep 2, 2015
@asvetlov
Copy link
Member Author

@asvetlov asvetlov commented Sep 3, 2015

@kxepal @fafhrd91 @popravich guys, do you agree with skip_auto_headers parameter name?

@fafhrd91
Copy link
Member

@fafhrd91 fafhrd91 commented Sep 3, 2015

maybe skip_default_headers ? or is it really auto headers?

@asvetlov
Copy link
Member Author

@asvetlov asvetlov commented Sep 3, 2015

@fafhrd91 it's autogenerated headers.
There is ambiguous for default headers meaning: we have autogenerated headers and ClientSession headers.
Both are used if the header is not specified directly but I don't want skip session's headers by the flag -- user can just don't pass the header into ClientSession constructor.

@fafhrd91
Copy link
Member

@fafhrd91 fafhrd91 commented Sep 3, 2015

ok, then it is fine.

asvetlov added 2 commits Sep 3, 2015
asvetlov added a commit that referenced this pull request Sep 3, 2015
Skip default headers
@asvetlov asvetlov merged commit c533d97 into master Sep 3, 2015
3 checks passed
3 checks passed
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@asvetlov asvetlov deleted the skip_default_headers branch Sep 3, 2015
@lock
Copy link

@lock lock bot commented Oct 30, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.