Skip to content

/ aiohttp

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add aiohttp-pydantic to third party libraries #5228

Merged
merged 2 commits into from Nov 14, 2020
Merged

Docs: Add aiohttp-pydantic to third party libraries #5228

merged 2 commits into from Nov 14, 2020

Conversation

@Maillol
Copy link
Contributor

@Maillol Maillol commented Nov 13, 2020

What do these changes do?

Add aiohttp-pydantic to third party libraries in the documentation.

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
@Maillol Maillol requested review from asvetlov and webknjaz as code owners Nov 13, 2020
@webknjaz
webknjaz reviewed Nov 14, 2020
View changes
docs/third_party.rst Outdated
@@ -139,6 +139,9 @@ period ask to raise the status.
- `aiohttp-validate <https://github.com/dchaplinsky/aiohttp_validate>`_
Simple library that helps you validate your API endpoints requests/responses with json schema.

- `aiohttp-pydantic <https://github.com/Maillol/aiohttp-pydantic>`_
An aiohttp.View to validate request body, qs and headers regarding function annotations and generate Open API doc. Python 3.8+ required.

This comment has been minimized.

Sign in to view
@webknjaz

webknjaz Nov 14, 2020
Member

Looks like the spellchecker doesn't like qs. Could you please change it? We need CI to be green before merging.

This comment has been minimized.

Sign in to view
@Maillol

Maillol Nov 14, 2020
Author Contributor

Sorry, I fixed that typo and added a change file in order to Timeline protection changes to green.

This comment has been minimized.

Sign in to view
@Maillol

Maillol Nov 14, 2020
Author Contributor

Is SAP SE the owner of aiohttp? The CLA assistant ask me to sign your License Agreement with SAP Se.

This comment has been minimized.

Sign in to view
@asvetlov

asvetlov Nov 14, 2020
Member

My fault. The CLA text was fixed.
Now it is pretty close to the Python CLA.
The reference is here: https://gist.github.com/asvetlov/dbce6679052f5c89d3d13f501107c1d4

Sorry for misleading.

This comment has been minimized.

Sign in to view
@Maillol

Maillol Nov 14, 2020
Author Contributor

Ok great! Now the received link point to right text. Thanks
@codecov
Copy link

@codecov codecov bot commented Nov 14, 2020 •
edited

Codecov Report

Merging #5228 (edbfa75) into master (021668a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5228   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files          43       43           
  Lines        8784     8784           
  Branches     1413     1413           
=======================================
  Hits         8568     8568           
  Misses        101      101           
  Partials      115      115
Flag Coverage Δ
unit 97.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021668a...edbfa75. Read the comment docs.
@Maillol
Add aiohttp-pydantic to third party libraries
Loading status checks…
d329519
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided label Nov 14, 2020
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Nov 14, 2020 •
edited

CLA assistant check
All committers have signed the CLA.
@asvetlov
asvetlov reviewed Nov 14, 2020
View changes
docs/third_party.rst Outdated Show resolved Hide resolved
@asvetlov
Update docs/third_party.rst
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
edbfa75
@asvetlov asvetlov added backport-3.7 backport-3.8 labels Nov 14, 2020
@asvetlov
asvetlov approved these changes Nov 14, 2020
View changes
@asvetlov asvetlov merged commit a2fef0f into aio-libs:master Nov 14, 2020
35 checks passed
35 checks passed
Autosquash
Details
Autosquash
Details
Autosquash
Details
Autosquash
Details
Backport Action
Details
Backport Action
Details
Backport Action
Details
Linter
Details
Test (3.6, ubuntu)
Details
Test (3.6, macos)
Details
Test (3.6, windows)
Details
Test (3.6, Y, ubuntu)
Details
Test (3.7, ubuntu)
Details
Test (3.7, windows)
Details
Test (3.7, Y, ubuntu)
Details
Test (3.8, ubuntu)
Details
Test (3.8, windows)
Details
Test (3.8, Y, ubuntu)
Details
Test (3.9, ubuntu)
Details
Test (3.9, macos)
Details
Test (3.9, windows)
Details
Test (3.9, Y, ubuntu)
Details
Test (pypy3, Y, ubuntu)
Details
Pre-Deploy
Details
Tarball
Details
Linux
Details
Binary wheels
Details
Deploy
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Backport This PR will be backported to: 3.7,3.8
Timeline protection Timeline protection: Good to go
Details
WIP Ready for review
Details
codecov/patch Coverage not affected when comparing 021668a...edbfa75
Details
license/cla Contributor License Agreement is signed.
Details
github-actions bot pushed a commit that referenced this pull request Nov 14, 2020
@Maillol @asvetlov asvetlov
Docs: Add aiohttp-pydantic to third party libraries (#5228)
Loading status checks…
de3760d 
* Add aiohttp-pydantic to third party libraries

* Update docs/third_party.rst

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@github-actions github-actions bot mentioned this pull request Nov 14, 2020
Merged
github-actions bot pushed a commit that referenced this pull request Nov 14, 2020
@Maillol @asvetlov asvetlov
Docs: Add aiohttp-pydantic to third party libraries (#5228)
Loading status checks…
ca44116 
* Add aiohttp-pydantic to third party libraries

* Update docs/third_party.rst

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@github-actions github-actions bot mentioned this pull request Nov 14, 2020
Merged
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 14, 2020

💚 Backport successful

The PR was backported to the following branches:
asvetlov added a commit that referenced this pull request Nov 14, 2020
@github-actions @Maillol @asvetlov
Docs: Add aiohttp-pydantic to third party libraries (#5228) (#5231)
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bd50c3c 
* Add aiohttp-pydantic to third party libraries

* Update docs/third_party.rst

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>

Co-authored-by: MAILLOL Vincent <vmaillol@webgeoservices.com>
Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
asvetlov added a commit that referenced this pull request Nov 14, 2020
@github-actions @Maillol @asvetlov
Docs: Add aiohttp-pydantic to third party libraries (#5228) (#5232)
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fc6fc92 
* Add aiohttp-pydantic to third party libraries

* Update docs/third_party.rst

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>

Co-authored-by: MAILLOL Vincent <vmaillol@webgeoservices.com>
Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov

@webknjaz webknjaz

Assignees
No one assigned
Labels
backport-3.8 bot:chronographer:provided
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Maillol @CLAassistant @asvetlov @webknjaz