Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] Fix speller blames (#5240) #5242

Merged
merged 1 commit into from Nov 16, 2020
Merged

[3.7] Fix speller blames (#5240) #5242

merged 1 commit into from Nov 16, 2020

Conversation

@asvetlov
Copy link
Member

@asvetlov asvetlov commented Nov 15, 2020

(cherry picked from commit 98b4c1d)

Co-authored-by: Andrew Svetlov andrew.svetlov@gmail.com

(cherry picked from commit 98b4c1d)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@asvetlov asvetlov requested a review from webknjaz as a code owner Nov 15, 2020
@codecov
Copy link

@codecov codecov bot commented Nov 15, 2020

Codecov Report

Merging #5242 (833e705) into 3.7 (e7bacea) will decrease coverage by 0.34%.
The diff coverage is 97.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.7    #5242      +/-   ##
==========================================
- Coverage   97.89%   97.55%   -0.35%     
==========================================
  Files          44       44              
  Lines        8951     8818     -133     
  Branches     1407     1419      +12     
==========================================
- Hits         8763     8602     -161     
- Misses         80      101      +21     
- Partials      108      115       +7     
Flag Coverage Δ
unit 97.39% <97.69%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_urldispatcher.py 97.59% <ø> (-1.52%) ⬇️
aiohttp/worker.py 96.72% <ø> (-0.82%) ⬇️
aiohttp/locks.py 92.85% <50.00%> (ø)
aiohttp/resolver.py 95.16% <75.00%> (-4.84%) ⬇️
aiohttp/pytest_plugin.py 97.56% <90.90%> (-0.02%) ⬇️
aiohttp/payload.py 94.93% <92.15%> (-0.89%) ⬇️
aiohttp/web_protocol.py 90.61% <92.98%> (+0.09%) ⬆️
aiohttp/web_routedef.py 98.09% <93.33%> (-1.91%) ⬇️
aiohttp/multipart.py 96.97% <94.61%> (ø)
aiohttp/cookiejar.py 99.17% <95.00%> (-0.83%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41eb5d0...833e705. Read the comment docs.

@asvetlov asvetlov merged commit 4f4470b into 3.7 Nov 16, 2020
25 of 27 checks passed
25 of 27 checks passed
Linter
Details
Test (3.6, ubuntu)
Details
Test (3.6, macos)
Details
Test (3.6, windows)
Details
Test (3.6, Y, ubuntu)
Details
Test (3.7, ubuntu)
Details
Test (3.7, windows)
Details
Test (3.7, Y, ubuntu)
Details
Test (3.8, ubuntu)
Details
Test (3.8, windows)
Details
Test (3.8, Y, ubuntu)
Details
Test (3.9, ubuntu)
Details
Test (3.9, macos)
Details
Test (3.9, windows)
Details
Test (3.9, Y, ubuntu)
Details
Test (pypy3, Y, ubuntu)
Details
Pre-Deploy
Details
Tarball
Details
Linux
Details
Binary wheels
Details
Deploy
Details
Timeline protection Timeline protection: History fragments missing
Details
codecov/patch 97.75% of diff hit (target 97.89%)
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@asvetlov asvetlov deleted the backport-98b4c1d-3.7 branch Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant