Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate timeout parameter in ClientSession reference docs. #5262

Merged
merged 1 commit into from Nov 22, 2020

Conversation

@gdub
Copy link
Contributor

@gdub gdub commented Nov 20, 2020

What do these changes do?

Removed duplicate timeout parameter in ClientSession reference docs.

Are there changes in behavior for the user?

n/a

Related issue number

n/a

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
@gdub gdub requested review from asvetlov and webknjaz as code owners Nov 20, 2020
@codecov
Copy link

@codecov codecov bot commented Nov 20, 2020

Codecov Report

Merging #5262 (2ea2e9f) into master (6f73339) will decrease coverage by 0.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5262      +/-   ##
==========================================
- Coverage   97.54%   97.07%   -0.47%     
==========================================
  Files          43       43              
  Lines        8794     8794              
  Branches     1415     1415              
==========================================
- Hits         8578     8537      -41     
- Misses        101      135      +34     
- Partials      115      122       +7     
Flag Coverage Δ
unit 96.95% <ø> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_runner.py 92.44% <0.00%> (-5.34%) ⬇️
aiohttp/tcp_helpers.py 94.73% <0.00%> (-5.27%) ⬇️
aiohttp/pytest_plugin.py 92.50% <0.00%> (-5.00%) ⬇️
aiohttp/connector.py 94.88% <0.00%> (-1.92%) ⬇️
aiohttp/web.py 97.45% <0.00%> (-1.70%) ⬇️
aiohttp/web_protocol.py 91.14% <0.00%> (-1.15%) ⬇️
aiohttp/test_utils.py 99.06% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f73339...2ea2e9f. Read the comment docs.

@aio-libs-github-bot
Copy link
Contributor

@aio-libs-github-bot aio-libs-github-bot bot commented Nov 22, 2020

💚 Backport successful

The PR was backported to the following branches:

asvetlov pushed a commit that referenced this issue Nov 22, 2020
…5262) (#5266)

Co-authored-by: Gary Wilson Jr <gary@thegarywilson.com>
asvetlov pushed a commit that referenced this issue Nov 22, 2020
…5262) (#5265)

Co-authored-by: Gary Wilson Jr <gary@thegarywilson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants