Drop Python 3.6 support #5278
Drop Python 3.6 support #5278
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
| @@ -5,8 +5,8 @@ | |||
|
|
|||
| from setuptools import Extension, setup | |||
|
|
|||
| if sys.version_info < (3, 6): | |||
| raise RuntimeError("aiohttp 4.x requires Python 3.6+") | |||
| if sys.version_info < (3, 7): | |||
There was a problem hiding this comment.
NOTE: I believe that with this change, we'll be able to migrate most of setup.py to setup.cfg since CPython 3.7.0 ships pip==10.0.1 and setuptools==39.0.1.
setup.cfg support was added in setuptools 30.3.0 and Requires-Python support has been added in pip 9.0.0.
Meaning that it's virtually impossible to hit this condition under the supported Python version. Add the platform wheels that we ship and you'll see that in 99% of cases users won't even run setup.py.
P.S. This is a topic for a separate PR, I just wanted to post some thoughts here.
There was a problem hiding this comment.
I support the proposal (in a separate PR) but don't want to apply the change myself.
Regarding binary wheels -- the case number 1 when people build from tarball are Alpine Linux users.
|
Looks like you also need to drop 3.6 from GHA |
Ooops. Done |
Codecov Report
@@ Coverage Diff @@
## master #5278 +/- ##
==========================================
- Coverage 97.53% 97.52% -0.01%
==========================================
Files 43 43
Lines 8818 8784 -34
Branches 1418 1410 -8
==========================================
- Hits 8601 8567 -34
- Misses 102 103 +1
+ Partials 115 114 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
(cherry picked from commit 0f0c375)
(cherry picked from commit 0f0c375)
(cherry picked from commit 0f0c375)
(cherry picked from commit 0f0c375)
Python 3.6 is close to EOL, aiohttp 4.0 is not released yet.
Dropping Python 3.6 for aiohttp 4.0 allows dropping a bunch of backward compatibility shims.