Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a distinct type for sentinel #5287

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Use a distinct type for sentinel #5287

merged 2 commits into from
Nov 25, 2020

Conversation

asvetlov
Copy link
Member

Before sentinel was processed as either object or Any, both variants are far from perfectness.

Now sentinel has a dedicated type which is not equal to anything.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 25, 2020
@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #5287 (57ba606) into master (7f73270) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5287   +/-   ##
=======================================
  Coverage   97.52%   97.53%           
=======================================
  Files          43       43           
  Lines        8784     8787    +3     
  Branches     1410     1410           
=======================================
+ Hits         8567     8570    +3     
  Misses        103      103           
  Partials      114      114           
Flag Coverage Δ
unit 97.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/connector.py 96.48% <100.00%> (ø)
aiohttp/helpers.py 96.78% <100.00%> (+<0.01%) ⬆️
aiohttp/payload.py 95.34% <100.00%> (+0.02%) ⬆️
aiohttp/test_utils.py 99.68% <100.00%> (ø)
aiohttp/web_request.py 97.61% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f73270...57ba606. Read the comment docs.

@asvetlov
Copy link
Member Author

The missing part is the Ellipsis (...) handling.
I very much appreciate if somebody bears this change.
Sure, I can help with the review etc.

@asvetlov asvetlov merged commit 082382b into master Nov 25, 2020
@asvetlov asvetlov deleted the better-typing branch November 25, 2020 18:44
@aio-libs-github-bot
Copy link
Contributor

💔 Backport was not successful

The PR was attempted backported to the following branches:

  • ❌ 3.8: Commit could not be cherrypicked due to conflicts

@asvetlov
Copy link
Member Author

Give up backpoting, should be ok as is.

commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant