Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Refactor OpenAPI/Swagger aiohttp addons #5326

Merged
merged 1 commit into from
Dec 15, 2020
Merged

DOC: Refactor OpenAPI/Swagger aiohttp addons #5326

merged 1 commit into from
Dec 15, 2020

Conversation

socketpair
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #5326 (c777840) into master (4ea49b7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5326   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          41       41           
  Lines        8739     8739           
  Branches     1402     1402           
=======================================
  Hits         8491     8491           
  Misses        129      129           
  Partials      119      119           
Flag Coverage Δ
unit 97.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ea49b7...c777840. Read the comment docs.

@socketpair
Copy link
Contributor Author

@asvetlov review

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please merge.
Backport to 3.8 is desirable as well

@socketpair socketpair merged commit 19170e4 into master Dec 15, 2020
@socketpair socketpair deleted the docs branch December 15, 2020 11:59
@aio-libs-github-bot
Copy link
Contributor

💔 Backport was not successful

The PR was attempted backported to the following branches:

  • ❌ 3.8: Commit could not be cherrypicked due to conflicts

@socketpair
Copy link
Contributor Author

@asvetlov how to make the backport ? new PR to another branch ?

@socketpair
Copy link
Contributor Author

What to do so ?

@asvetlov
Copy link
Member

cherry_picker 19170e4 3.8

Sorry for late reply.

asvetlov pushed a commit that referenced this pull request Dec 17, 2020
(cherry picked from commit 19170e4)

Co-authored-by: Коренберг Марк <mark@ideco.ru>
asvetlov added a commit that referenced this pull request Dec 17, 2020
…5353)

(cherry picked from commit 19170e4)

Co-authored-by: Коренберг Марк <mark@ideco.ru>
@asvetlov
Copy link
Member

Backported

commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants