Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for 0 timeout #5533

Merged
merged 5 commits into from
Mar 12, 2021
Merged

Add test for 0 timeout #5533

merged 5 commits into from
Mar 12, 2021

Conversation

Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Mar 10, 2021

Regression test ported from #5529, plus minor refactoring of ceil_timeout().

@Dreamsorcerer Dreamsorcerer requested a review from asvetlov as a code owner March 10, 2021 20:08
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #5533 (b7bd646) into master (71f574f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5533   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          41       41           
  Lines        8854     8854           
  Branches     1424     1424           
=======================================
  Hits         8604     8604           
  Misses        133      133           
  Partials      117      117           
Flag Coverage Δ
unit 97.06% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/helpers.py 96.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f574f...b7bd646. Read the comment docs.

@webknjaz webknjaz merged commit 3f94bb8 into master Mar 12, 2021
@webknjaz webknjaz deleted the Dreamsorcerer-patch-3 branch March 12, 2021 23:21
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants