Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated setup.py invocations with build in CI #6166

Merged
merged 4 commits into from
Oct 28, 2021

Conversation

webknjaz
Copy link
Member

What do these changes do?

https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html

Are there changes in behavior for the user?

No.

Related issue number

N/A

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2021
@webknjaz webknjaz enabled auto-merge (squash) October 28, 2021 20:51
@webknjaz webknjaz enabled auto-merge (squash) October 28, 2021 20:51
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #6166 (1507c53) into master (06e653d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6166   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files         102      102           
  Lines       30230    30230           
  Branches     2711     2711           
=======================================
  Hits        28204    28204           
  Misses       1849     1849           
  Partials      177      177           
Flag Coverage Δ
unit 93.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e653d...1507c53. Read the comment docs.

@webknjaz webknjaz merged commit 5bb202a into master Oct 28, 2021
@webknjaz webknjaz deleted the maintenance/pypa-build branch October 28, 2021 21:08
@patchback
Copy link
Contributor

patchback bot commented Oct 28, 2021

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/5bb202a9d7b1d4861732f7d8714a13c107e999fd/pr-6166

Backported as #6167

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

webknjaz added a commit that referenced this pull request Oct 28, 2021
…ations with `build` in CI (#6167)

Ref: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html
(cherry picked from commit 5bb202a)

Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR enhancement infra meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant