Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cookie share example in docs (and make a bit verbose) #817

Merged
merged 1 commit into from Mar 7, 2016

Conversation

@popravich
Copy link
Member

@popravich popravich commented Mar 7, 2016

What these changes does?

Fix sample code in client docs

How to test your changes?

copy-paste-run

Related issue number

I believe this is related to misunderstanding in #815

Checklist

  • Code is written and well
  • Tests for the changes are provided
  • Documentation reflects the changes
@popravich popravich mentioned this pull request Mar 7, 2016
@kxepal
Copy link
Member

@kxepal kxepal commented Mar 7, 2016

+1

@asvetlov asvetlov added this to the 0.22 milestone Mar 7, 2016
@asvetlov
Copy link
Member

@asvetlov asvetlov commented Mar 7, 2016

Cool!
Please merge

popravich added a commit that referenced this pull request Mar 7, 2016
fix cookie share example in docs (and make a bit verbose)
@popravich popravich merged commit 2af780f into master Mar 7, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@popravich popravich deleted the doc_example_fix branch Mar 7, 2016
@lock
Copy link

@lock lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.