Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accuracy of subapp resource types #8364

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Conversation

Dreamsorcerer
Copy link
Member

No description provided.

@Dreamsorcerer Dreamsorcerer added the backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot label Apr 20, 2024
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.61%. Comparing base (9b6f2c0) to head (aeb9f8a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8364   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files         107      107           
  Lines       33092    33093    +1     
  Branches     3887     3887           
=======================================
+ Hits        32303    32304    +1     
  Misses        572      572           
  Partials      217      217           
Flag Coverage Δ
CI-GHA 97.53% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.19% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.60% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.86% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 95.45% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 96.99% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.19% <100.00%> (+<0.01%) ⬆️
Py-3.12.3 97.31% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 95.37% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.85% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 95.42% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 96.97% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.15 96.51% <100.00%> (-0.01%) ⬇️
VM-macos 96.86% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.19% <100.00%> (+<0.01%) ⬆️
VM-windows 95.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 20, 2024
@Dreamsorcerer Dreamsorcerer merged commit 0e4a5c3 into master Apr 20, 2024
38 of 39 checks passed
@Dreamsorcerer Dreamsorcerer deleted the improve-subapp-typing branch April 20, 2024 18:39
Copy link
Contributor

patchback bot commented Apr 20, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/0e4a5c3c851fecb516e5a3d444f8598dcf340ef4/pr-8364

Backported as #8366

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 20, 2024
Dreamsorcerer added a commit that referenced this pull request Apr 20, 2024
…e types (#8366)

**This is a backport of PR #8364 as merged into master
(0e4a5c3).**

Co-authored-by: Sam Bull <git@sambull.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant