Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old backwards-compatibility stub #8596

Merged
merged 6 commits into from
Aug 3, 2024
Merged

Remove old backwards-compatibility stub #8596

merged 6 commits into from
Aug 3, 2024

Conversation

Dreamsorcerer
Copy link
Member

Closes #2164.

According to the linked issue this was supposed to be removed in v3.

@Dreamsorcerer Dreamsorcerer added the backport:skip Skip backport bot label Aug 2, 2024
@Dreamsorcerer Dreamsorcerer requested a review from asvetlov as a code owner August 2, 2024 23:36
@Dreamsorcerer Dreamsorcerer requested a review from webknjaz as a code owner August 2, 2024 23:38
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 2, 2024
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 98.73418% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.70%. Comparing base (bc0878b) to head (4e4d3e8).
Report is 860 commits behind head on master.

Files with missing lines Patch % Lines
tests/test_web_functional.py 98.85% 1 Missing ⚠️
tests/test_web_urldispatcher.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8596      +/-   ##
==========================================
- Coverage   97.70%   97.70%   -0.01%     
==========================================
  Files         107      107              
  Lines       33443    33438       -5     
  Branches     3927     3927              
==========================================
- Hits        32677    32672       -5     
  Misses        555      555              
  Partials      211      211              
Flag Coverage Δ
CI-GHA 97.61% <98.73%> (-0.01%) ⬇️
OS-Linux 97.27% <98.73%> (-0.01%) ⬇️
OS-Windows 95.64% <98.73%> (-0.01%) ⬇️
OS-macOS 96.94% <98.73%> (+<0.01%) ⬆️
Py-3.10.11 97.08% <98.73%> (-0.01%) ⬇️
Py-3.10.14 97.02% <98.73%> (-0.01%) ⬇️
Py-3.11.9 97.25% <98.73%> (-0.01%) ⬇️
Py-3.12.4 97.38% <98.73%> (+<0.01%) ⬆️
Py-3.8.10 95.40% <98.73%> (-0.01%) ⬇️
Py-3.8.18 96.91% <98.73%> (-0.01%) ⬇️
Py-3.9.13 97.07% <98.73%> (-0.01%) ⬇️
Py-3.9.19 97.02% <98.73%> (-0.01%) ⬇️
Py-pypy7.3.16 96.59% <98.73%> (-0.01%) ⬇️
VM-macos 96.94% <98.73%> (+<0.01%) ⬆️
VM-ubuntu 97.27% <98.73%> (-0.01%) ⬇️
VM-windows 95.64% <98.73%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit c13be49 into master Aug 3, 2024
37 of 38 checks passed
@Dreamsorcerer Dreamsorcerer deleted the cleanup-noop branch August 3, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip Skip backport bot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: ClientResponse.release is not a coroutine
1 participant