Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version from set_cookie() #8957

Merged
merged 4 commits into from
Aug 31, 2024
Merged

Conversation

Dreamsorcerer
Copy link
Member

The version attribute no longer exists in https://datatracker.ietf.org/doc/html/rfc6265

@Dreamsorcerer Dreamsorcerer added the backport:skip Skip backport bot label Aug 31, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 31, 2024
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (51ea3b3) to head (591793d).
Report is 1070 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8957      +/-   ##
==========================================
- Coverage   98.27%   98.27%   -0.01%     
==========================================
  Files         107      107              
  Lines       34226    34224       -2     
  Branches     4058     4057       -1     
==========================================
- Hits        33637    33635       -2     
  Misses        416      416              
  Partials      173      173              
Flag Coverage Δ
CI-GHA 98.17% <ø> (-0.01%) ⬇️
OS-Linux 97.83% <ø> (-0.01%) ⬇️
OS-Windows 96.24% <ø> (-0.01%) ⬇️
OS-macOS 97.51% <ø> (-0.01%) ⬇️
Py-3.10.11 97.60% <ø> (-0.01%) ⬇️
Py-3.10.14 97.53% <ø> (-0.01%) ⬇️
Py-3.11.9 97.77% <ø> (-0.01%) ⬇️
Py-3.12.5 97.88% <ø> (-0.01%) ⬇️
Py-3.9.13 97.49% <ø> (-0.01%) ⬇️
Py-3.9.19 97.43% <ø> (-0.01%) ⬇️
Py-pypy7.3.16 97.04% <ø> (+<0.01%) ⬆️
VM-macos 97.51% <ø> (-0.01%) ⬇️
VM-ubuntu 97.83% <ø> (-0.01%) ⬇️
VM-windows 96.24% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 51fade1 into master Aug 31, 2024
34 of 35 checks passed
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-5 branch August 31, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip Skip backport bot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant