Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove None as a compress value #9109

Merged
merged 3 commits into from
Sep 22, 2024
Merged

Remove None as a compress value #9109

merged 3 commits into from
Sep 22, 2024

Conversation

Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Sep 10, 2024

Changed default value to compress from None to False (None is no longer an expected value)

@Dreamsorcerer Dreamsorcerer added the backport:skip Skip backport bot label Sep 10, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (1d11241) to head (6b24fac).
Report is 1097 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9109      +/-   ##
==========================================
- Coverage   98.30%   98.30%   -0.01%     
==========================================
  Files         107      107              
  Lines       34427    34425       -2     
  Branches     4085     4084       -1     
==========================================
- Hits        33844    33842       -2     
  Misses        411      411              
  Partials      172      172              
Flag Coverage Δ
CI-GHA 98.20% <100.00%> (-0.01%) ⬇️
OS-Linux 97.86% <100.00%> (-0.01%) ⬇️
OS-Windows 96.27% <100.00%> (-0.01%) ⬇️
OS-macOS 97.54% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.63% <100.00%> (-0.01%) ⬇️
Py-3.10.14 97.57% <100.00%> (-0.01%) ⬇️
Py-3.11.9 97.80% <100.00%> (-0.01%) ⬇️
Py-3.12.5 97.91% <100.00%> (-0.01%) ⬇️
Py-3.9.13 97.52% <100.00%> (-0.01%) ⬇️
Py-3.9.19 97.46% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 97.08% <100.00%> (-0.01%) ⬇️
VM-macos 97.54% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.86% <100.00%> (-0.01%) ⬇️
VM-windows 96.27% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit b34a32c into master Sep 22, 2024
35 of 36 checks passed
@bdraco bdraco deleted the remove-compress-none branch September 22, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip Skip backport bot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants