Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creating handler waiter until shutdown #9168

Merged
merged 7 commits into from
Sep 21, 2024
Merged

Avoid creating handler waiter until shutdown #9168

merged 7 commits into from
Sep 21, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 17, 2024 •
edited
Loading

What do these changes do?

Every request created _handler_waiter. Instead only create it when we need to wait for graceful shutdown. Avoids one future creation for every request if we are not shutting down.

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

related issue #2779

profile

before
handle_request_before

after
handle_request_after

@bdraco
Avoid creating handler waiter until shutdown
9f33144 
Every request created _handler_waiter. Instead only create it
when we need to wait for graceful shutdown
@bdraco bdraco added backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 17, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.31%. Comparing base (98b363e) to head (94fcfef).
Report is 1069 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9168   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         107      107           
  Lines       34485    34489    +4     
  Branches     4095     4096    +1     
=======================================
+ Hits        33903    33907    +4     
  Misses        411      411           
  Partials      171      171
Flag Coverage Δ
CI-GHA 98.20% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.87% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.28% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.54% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.64% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.58% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.47% <100.00%> (?)
Py-3.11.9 97.53% <100.00%> (-0.28%) ⬇️
Py-3.12.5 97.58% <100.00%> (+<0.01%) ⬆️
Py-3.12.6 97.64% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.53% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 97.47% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.08% <100.00%> (+<0.01%) ⬆️
VM-macos 97.54% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.87% <100.00%> (+<0.01%) ⬆️
VM-windows 96.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 18, 2024
@bdraco bdraco marked this pull request as ready for review September 18, 2024 05:51
bdraco
bdraco commented Sep 18, 2024
View reviewed changes
aiohttp/web_protocol.py Outdated Show resolved Hide resolved
bdraco
bdraco commented Sep 18, 2024
View reviewed changes
aiohttp/web_protocol.py Outdated Show resolved Hide resolved
@bdraco bdraco merged commit 5e15ea6 into master Sep 21, 2024
34 of 35 checks passed
@bdraco bdraco deleted the no_future_if_not_needed branch September 21, 2024 09:16
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 21, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/5e15ea61d2ed9284512cb4deaace70531d5c65be/pr-9168

Backported as #9210

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 21, 2024
@bdraco @patchback
Avoid creating handler waiter until shutdown (#9168)
730277f 
(cherry picked from commit 5e15ea6)
@patchback patchback bot mentioned this pull request Sep 21, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 21, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/5e15ea61d2ed9284512cb4deaace70531d5c65be/pr-9168

Backported as #9211

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 21, 2024
@bdraco @patchback
Avoid creating handler waiter until shutdown (#9168)
a118ce0 
(cherry picked from commit 5e15ea6)
@patchback patchback bot mentioned this pull request Sep 21, 2024
Merged
bdraco pushed a commit that referenced this pull request Sep 21, 2024
@patchback
[PR #9168/5e15ea61 backport][3.10] Avoid creating handler waiter unti…
2b11f5e 
…l shutdown (#9210)
bdraco pushed a commit that referenced this pull request Sep 21, 2024
@patchback
[PR #9168/5e15ea61 backport][3.11] Avoid creating handler waiter unti…
0408ba6 
…l shutdown (#9211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dreamsorcerer Dreamsorcerer Dreamsorcerer left review comments

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @Dreamsorcerer