-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small speed up to starting web requests #9241
Conversation
Since we will almost always set the PayloadAccessError on the payload, only create it once related issue #2779
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9241 +/- ##
=======================================
Coverage 98.42% 98.42%
=======================================
Files 107 107
Lines 34715 34716 +1
Branches 4116 4116
=======================================
+ Hits 34168 34169 +1
Misses 380 380
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 7e0ef07 on top of patchback/backports/3.10/7e0ef0748c206d628e414dc20c033d67f94b2172/pr-9241 Backporting merged PR #9241 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 7e0ef07 on top of patchback/backports/3.11/7e0ef0748c206d628e414dc20c033d67f94b2172/pr-9241 Backporting merged PR #9241 into master
🤖 @patchback |
(cherry picked from commit 7e0ef07)
(cherry picked from commit 7e0ef07)
Since we will almost always set the
PayloadAccessErroron the payload, only create it oncerelated issue #2779
Its a small speed up, but its also a very simple change. Test with HA -> Requests/sec: 28222.98 -> Requests/sec: 28884.79