Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small speed up to starting web requests #9241

Merged
merged 3 commits into from
Sep 22, 2024
Merged

Small speed up to starting web requests #9241

merged 3 commits into from
Sep 22, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 22, 2024

Since we will almost always set the PayloadAccessError on the payload, only create it once

related issue #2779

Its a small speed up, but its also a very simple change. Test with HA -> Requests/sec: 28222.98 -> Requests/sec: 28884.79

Since we will almost always set the PayloadAccessError on
the payload, only create it once

related issue #2779
@bdraco bdraco added backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 22, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 22, 2024
@bdraco bdraco marked this pull request as ready for review September 22, 2024 19:06
@bdraco bdraco enabled auto-merge (squash) September 22, 2024 20:47
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (76c6010) to head (2e3b556).
Report is 1046 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9241   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files         107      107           
  Lines       34715    34716    +1     
  Branches     4116     4116           
=======================================
+ Hits        34168    34169    +1     
  Misses        380      380           
  Partials      167      167           
Flag Coverage Δ
CI-GHA 98.30% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.97% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.36% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.65% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.74% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.67% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.57% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.64% <100.00%> (+<0.01%) ⬆️
Py-3.12.6 98.02% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.62% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.57% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.18% <100.00%> (+<0.01%) ⬆️
VM-macos 97.65% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.97% <100.00%> (+<0.01%) ⬆️
VM-windows 96.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 7e0ef07 into master Sep 22, 2024
32 of 33 checks passed
@bdraco bdraco deleted the payload_access_error branch September 22, 2024 23:12
Copy link
Contributor

patchback bot commented Sep 22, 2024

Backport to 3.10: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 7e0ef07 on top of patchback/backports/3.10/7e0ef0748c206d628e414dc20c033d67f94b2172/pr-9241

Backporting merged PR #9241 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.10/7e0ef0748c206d628e414dc20c033d67f94b2172/pr-9241 upstream/3.10
  4. Now, cherry-pick PR Small speed up to starting web requests #9241 contents into that branch:
    $ git cherry-pick -x 7e0ef0748c206d628e414dc20c033d67f94b2172
    If it'll yell at you with something like fatal: Commit 7e0ef0748c206d628e414dc20c033d67f94b2172 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 7e0ef0748c206d628e414dc20c033d67f94b2172
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Small speed up to starting web requests #9241 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.10/7e0ef0748c206d628e414dc20c033d67f94b2172/pr-9241
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Sep 22, 2024

Backport to 3.11: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 7e0ef07 on top of patchback/backports/3.11/7e0ef0748c206d628e414dc20c033d67f94b2172/pr-9241

Backporting merged PR #9241 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.11/7e0ef0748c206d628e414dc20c033d67f94b2172/pr-9241 upstream/3.11
  4. Now, cherry-pick PR Small speed up to starting web requests #9241 contents into that branch:
    $ git cherry-pick -x 7e0ef0748c206d628e414dc20c033d67f94b2172
    If it'll yell at you with something like fatal: Commit 7e0ef0748c206d628e414dc20c033d67f94b2172 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 7e0ef0748c206d628e414dc20c033d67f94b2172
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Small speed up to starting web requests #9241 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.11/7e0ef0748c206d628e414dc20c033d67f94b2172/pr-9241
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

bdraco added a commit that referenced this pull request Sep 22, 2024
bdraco added a commit that referenced this pull request Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant