-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix double unquoting in url dispatcher #9267
Conversation
#8898 now passes the unquoted path and we would unquote it again
|
If this passes the CI than we likely have a gap in test coverage |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9267 +/- ##
==========================================
+ Coverage 97.79% 98.41% +0.62%
==========================================
Files 108 107 -1
Lines 34949 34828 -121
Branches 4170 4132 -38
==========================================
+ Hits 34178 34277 +99
+ Misses 574 380 -194
+ Partials 197 171 -26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This reverts commit 2731a1a.
…F is no longer decoded" This reverts commit 71a2b7d.
…_double_unquoting
…_double_unquoting
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 947b9c4 on top of patchback/backports/3.10/947b9c43374a2d6a73baab31c5f4bc106d4683ef/pr-9267 Backporting merged PR #9267 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 947b9c4 on top of patchback/backports/3.11/947b9c43374a2d6a73baab31c5f4bc106d4683ef/pr-9267 Backporting merged PR #9267 into master
🤖 @patchback |
Co-authored-by: Sam Bull <git@sambull.org> (cherry picked from commit 947b9c4)
Co-authored-by: Sam Bull <git@sambull.org> (cherry picked from commit 947b9c4)
…her (#9269) Co-authored-by: Sam Bull <git@sambull.org>
…her (#9270) Co-authored-by: Sam Bull <git@sambull.org>
|
all passing now. I think we are good to do the stable release |
#8898 now passes the unquoted path and we would unquote it again. To fix this we need to bump the minimum yarl version to 1.12.0 and use the new
URL.path_safemethod. This is done in a single PR since the yarl bump has a revert in it that is breaking (only for unreleased/non-stable versions ofaiohttp) without this change.