Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9340/8a97e03 backport][3.11] Use dunder writer internally in ClientResponse #9342

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 29, 2024

(cherry picked from commit 8a97e03)

@bdraco bdraco changed the title Use dunder writer internally in ClientResponse (#9340) [PR #9340/8a97e03 backport][3.10] Use dunder writer internally in ClientResponse Sep 29, 2024
@bdraco bdraco changed the title [PR #9340/8a97e03 backport][3.10] Use dunder writer internally in ClientResponse [PR #9340/8a97e03 backport][3.11] Use dunder writer internally in ClientResponse Sep 29, 2024
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Sep 29, 2024
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.79%. Comparing base (e1890ae) to head (1cc239a).
Report is 357 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.11    #9342      +/-   ##
==========================================
- Coverage   97.80%   97.79%   -0.01%     
==========================================
  Files         108      108              
  Lines       35014    35014              
  Branches     4180     4180              
==========================================
- Hits        34245    34243       -2     
- Misses        573      574       +1     
- Partials      196      197       +1     
Flag Coverage Δ
CI-GHA 97.67% <100.00%> (-0.01%) ⬇️
OS-Linux 97.36% <100.00%> (-0.01%) ⬇️
OS-Windows 94.94% <100.00%> (-0.01%) ⬇️
OS-macOS 97.06% <100.00%> (-0.01%) ⬇️
Py-3.10.11 96.93% <100.00%> (-0.01%) ⬇️
Py-3.10.15 96.86% <100.00%> (-0.01%) ⬇️
Py-3.11.10 96.93% <100.00%> (-0.01%) ⬇️
Py-3.11.9 97.00% <100.00%> (-0.01%) ⬇️
Py-3.12.6 97.40% <100.00%> (-0.01%) ⬇️
Py-3.13.0-rc.2 97.38% <100.00%> (-0.01%) ⬇️
Py-3.9.13 96.84% <100.00%> (-0.01%) ⬇️
Py-3.9.20 96.78% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 96.38% <100.00%> (-0.01%) ⬇️
VM-macos 97.06% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.36% <100.00%> (-0.01%) ⬇️
VM-windows 94.94% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review September 29, 2024 15:04
@bdraco bdraco requested a review from asvetlov as a code owner September 29, 2024 15:04
@bdraco bdraco merged commit ebee448 into 3.11 Sep 29, 2024
34 of 35 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/8a97e03b447d58b8ca0f675dffebb1c05727b286/pr-9340 branch September 29, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant