Remove unused ip address helpers #9344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are now unused
bdraco
added
the
backport-3.11
psf-chronographer
bot
added
the
bot:chronographer:provided
|
memoryview didn't actually work also we never pass anything but string |
bdraco
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9344 +/- ##
==========================================
- Coverage 98.56% 98.55% -0.01%
==========================================
Files 107 107
Lines 34942 34910 -32
Branches 4145 4136 -9
==========================================
- Hits 34439 34407 -32
Misses 335 335
Partials 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9349 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 29, 2024
(cherry picked from commit ea991a9)
bdraco
added a commit
that referenced
this pull request
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Remove
is_ipv6_addressandis_ipv4_addresshelpers as they are not used in the codebase anymore. Not back-ported to 3.10 since there is still back-compat code that uses them.Remove support for
bytes/bytesarray/memoryviewfromis_ip_addressas its never used. Also passing amemoryviewdid not work so there was no chance it was being used.Are there changes in behavior for the user?
The helpers have been removed. They are not expected to be called externally, however in case someone was using them, this was marked as a breaking change.
Is it a substantial burden for the maintainers to support this?
no