Ensure Cython WebSocket parser can handle frames of 2**23 in size #9781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is technically allowed if the limit is increased high enough https://www.rfc-editor.org/rfc/rfc6455#section-5.2 However its unlikely to happen since you would need 9.22 exabytes of RAM assuming there is no copy of the message ever
bdraco
added
the
backport-3.11
psf-chronographer
bot
added
the
bot:chronographer:provided
CodSpeed Performance ReportMerging #9781 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9781 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 117 117
Lines 35968 35968
Branches 4276 4276
=======================================
Hits 35494 35494
Misses 319 319
Partials 155 155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9782 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 10, 2024
) (cherry picked from commit 8116257)
bdraco
added a commit
that referenced
this pull request
Nov 10, 2024
… handle frames of 2**23 in size (#9782) Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This is technically allowed if the limit is increased high enough https://www.rfc-editor.org/rfc/rfc6455#section-5.2
However its unlikely to happen since you would need at least 9.22 exabytes of RAM assuming there is no copy of the message ever
The default max message size is 4194304 so this went unnoticed
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no