Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentinel discovery fix #380

Merged
merged 2 commits into from Feb 15, 2018

Conversation

@popravich
Copy link
Member

commented Feb 15, 2018

Fix issue with Sentinel client and ConnectionsPool causing endless reconnect on service discovery.

ConnectionsPool._fill_free was always calling ManagedPool._create_new_connection with _NON_DISCOVERED address marker causing ManagedPool to clear all currently established connections.
So setting minsize value greater then 1 was putting _fill_free in endless loop.

@popravich popravich added the bug label Feb 15, 2018

@popravich popravich merged commit 1bcde41 into master Feb 15, 2018

2 of 4 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@popravich popravich deleted the sentinel_discovery_fix branch Feb 15, 2018

@popravich popravich added this to the v1.1 milestone Feb 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.