Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project specific PR template, including CONTRIBUTORS.txt #600

Merged
merged 3 commits into from May 30, 2019

Conversation

Projects
None yet
2 participants
@Mariatta
Copy link
Member

commented May 30, 2019

Add aioredis-specific PR template, that includes CONTRIBUTORS.txt

Related to proposed PR for removing CONTRIBUTORS.txt from the global PR template
aio-libs/.github#3

@Mariatta Mariatta referenced this pull request May 30, 2019

Closed

Mention that CONTRIBUTORS.txt doesn't apply to all repos #2

1 of 5 tasks complete
@webknjaz
Copy link
Member

left a comment

LGTM but I think those few improvements may be handy

@codecov

This comment has been minimized.

Copy link

commented May 30, 2019

Codecov Report

Merging #600 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #600   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files          57       57           
  Lines        8431     8431           
  Branches      567      567           
=======================================
  Hits         8167     8167           
  Misses        188      188           
  Partials       76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8c33e3...0f10f72. Read the comment docs.

Mariatta and others added some commits May 30, 2019

Update .github/PULL_REQUEST_TEMPLATE.md
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Update .github/PULL_REQUEST_TEMPLATE.md
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
@Mariatta

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

Makes sense. Updated, thanks!

@webknjaz webknjaz merged commit 7765dff into aio-libs:master May 30, 2019

3 of 6 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Travis CI - Pull Request Build Passed
Details
security/snyk - docs/requirements.txt (aio-libs) No manifest changes detected
security/snyk - tests/requirements.txt (aio-libs) No manifest changes detected

@Mariatta Mariatta deleted the Mariatta:patch-1 branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.