Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close all pubsub channels when connection is closed #88

Merged
merged 1 commit into from Oct 20, 2015

Conversation

@ciscorn
Copy link
Contributor

commented Oct 19, 2015

Without this, Channel.wait_message() doesn't return nor raise any exceptions when the connection is lost.

popravich added a commit that referenced this pull request Oct 20, 2015
Merge pull request #88 from ciscorn/master
Close all pubsub channels when connection is closed

@popravich popravich merged commit 74cfe7b into aio-libs:master Oct 20, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@popravich

This comment has been minimized.

Copy link
Member

commented Oct 20, 2015

thanks

@asvetlov

This comment has been minimized.

Copy link
Member

commented Oct 20, 2015

@popravich please update CHANGES.txt also

@popravich

This comment has been minimized.

Copy link
Member

commented Oct 20, 2015

I'm doing this before each release

@asvetlov

This comment has been minimized.

Copy link
Member

commented Oct 20, 2015

Well, that's up to you. I prefer update CHANGES after every merge to don't forget something important.

@popravich

This comment has been minimized.

Copy link
Member

commented Oct 20, 2015

True, but don't worry, I do git log <old_tag>..HEAD every time to check everything)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.