From d48b15b0d8e0b11ee31c31806306c0475dc43128 Mon Sep 17 00:00:00 2001
From: Martijn Pieters <github.com@zopatista.com>
Date: Tue, 8 Nov 2022 13:27:01 +0000
Subject: [PATCH] CI: detect test matrix failure correctly (#354)

We were missing always(), and use the alls-green action to verify the status of
the test matrix jobs. Without always() the check step was being skipped
whenever a test failed. :facepalm:
---
 .github/workflows/ci.yml | 8 +++++---
 CHANGES/327.misc         | 1 +
 2 files changed, 6 insertions(+), 3 deletions(-)
 create mode 100644 CHANGES/327.misc

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index dff6d469..5c0602f7 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -120,10 +120,12 @@ jobs:
     name: Test matrix status
     runs-on: ubuntu-latest
     needs: [test]
+    if: always()
     steps:
-      - name: Check build matrix status
-        if: needs.test.result != 'success'
-        run: exit 1
+    - name: Decide whether the needed jobs succeeded or failed
+      uses: re-actors/alls-green@release/v1
+      with:
+        jobs: ${{ toJSON(needs) }}
 
   pre-deploy:
     name: Pre-Deploy
diff --git a/CHANGES/327.misc b/CHANGES/327.misc
new file mode 100644
index 00000000..ab9ae092
--- /dev/null
+++ b/CHANGES/327.misc
@@ -0,0 +1 @@
+Updated the CI runs to better check for test results and to avoid deprecated syntax.