-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental 3.11 tests #292
Conversation
Well, that's weird. pytest just fails with no output... |
9188ff3
to
08c6bd2
Compare
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 1 1
Lines 61 61
Branches 7 10 +3
=======================================
Hits 60 60
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. |
Will |
I'll try it out later, when I've got time. But, feel free to branch off and get it working before me. |
Approved them. |
Upgrading all dependencies in |
08c6bd2
to
de65612
Compare
The failing test is being run on pytest==6.2.5, not the current version. https://pypi.org/project/pytest Upgrading all dependencies in |
OK, dependabot needs to be fixed for this project. It's only updating things in the github workflow, not Python requirements files.. |
Yeah, I noticed that but couldn't figure out why that's happening, looking at the config. Does it need to be pointed at a different folder? |
include: | ||
- os: ubuntu | ||
pyver: "3.11.0-alpha - 3.11.0" | ||
experimental: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, if it passes, maybe we don't need "experimental" anymore? The first release candidate is just a week away, after all...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm inclined to just leave an experimental version in, so it can just be bumped to 3.12 a little later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too late 15b0085
It appears to be the same in aiohttp, so no idea why it's not activating here. |
No description provided.