Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix join calls not raise RuntimeError after queue closing. #295

Merged
merged 3 commits into from Oct 26, 2020

Conversation

@linw1995
Copy link
Contributor

@linw1995 linw1995 commented Oct 21, 2020

What do these changes do?

Fix join() method calls not raise RuntimeError after queue closing.

Are there changes in behavior for the user?

The join() method calls will raise RuntimeError after queue closing.

Related issue number

#294

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
@codecov
Copy link

@codecov codecov bot commented Oct 21, 2020

Codecov Report

Merging #295 into master will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
+ Coverage   95.30%   95.52%   +0.21%     
==========================================
  Files           4        4              
  Lines        1215     1274      +59     
  Branches       84       84              
==========================================
+ Hits         1158     1217      +59     
  Misses         50       50              
  Partials        7        7              
Flag Coverage Δ
#unit 95.52% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
janus/__init__.py 99.68% <100.00%> (+<0.01%) ⬆️
tests/test_mixed.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 221c14d...b703a20. Read the comment docs.

janus/__init__.py Outdated Show resolved Hide resolved
Copy link
Member

@asvetlov asvetlov left a comment

LGTM!

@asvetlov asvetlov merged commit df9c4f8 into aio-libs:master Oct 26, 2020
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants