New filters in builtin module

[JrooTJunior]

Next list of filters is planned for implementation in builtin module and registered in filters factory:

• Chat id (aiogram#1544) - PR: Add id filter #172
• User id (aiogram#1544) - PR: Add id filter #172
• User is admin in chat (aiogram#1549, aiogram#1555) - PR: Create AdminFilter and rename IdFilter to IDFilter #182
• Message is reply to another message (aiogram#1549) - PR: add IsReplyFilter #210, Fixed missed IsReplyFilter import #212
• Message forwarded (aiogram#1549) - PR: feat: ForwardedMessage filter #355
• Move chat type filters (aiogram#1549)
• Multiple text filter (aiogram_ru#73126)
• check that the contact matches the sender - commit

[Birdi7]

I would like to work on Multiple text filter. But I have a question regarding the key word. Should it be text for both single and muliple elements, text for single and texts for a list, or texts for both single and multiple elements(like it's done in commands filter)? @JrooTJunior what do you think about it?

[Forevka]

Maybe it will be useful:

Checking if message from group

class IsGroup(Filter):
    """
        Check if chat is group
    """

    async def check(self, obj: Union[Message, CallbackQuery], *args):
        if isinstance(obj, Message):
            return obj.chat.id < 0
        return obj.message.chat.id < 0

Check if message from private

class IsPrivate(Filter):
    async def check(self, obj: Union[Message, CallbackQuery], *args):
        return obj.chat.id == obj.from_user.id

Check message text in list

class IsTextInList(Filter):
    def __init__(self, text_list):
        self.text_list = text_list

    async def check(self, obj: Union[Message, CallbackQuery], *args):
        return obj.text in self.text_list

[JrooTJunior]

@Forevka69, filters for chat types is already implemented in types.ChatType object:

aiogram/aiogram/types/chat.py

Lines 423 to 479 in e77f514

	@staticmethod
	def _check(obj, chat_types) -> bool:
	if hasattr(obj, 'chat'):
	obj = obj.chat
	if not hasattr(obj, 'type'):
	return False
	return obj.type in chat_types
	@classmethod
	def is_private(cls, obj) -> bool:
	"""
	Check chat is private
	:param obj:
	:return:
	"""
	return cls._check(obj, [cls.PRIVATE])
	@classmethod
	def is_group(cls, obj) -> bool:
	"""
	Check chat is group
	:param obj:
	:return:
	"""
	return cls._check(obj, [cls.GROUP])
	@classmethod
	def is_super_group(cls, obj) -> bool:
	"""
	Check chat is super-group
	:param obj:
	:return:
	"""
	return cls._check(obj, [cls.SUPER_GROUP])
	@classmethod
	def is_group_or_super_group(cls, obj) -> bool:
	"""
	Check chat is group or super-group
	:param obj:
	:return:
	"""
	return cls._check(obj, [cls.GROUP, cls.SUPER_GROUP])
	@classmethod
	def is_channel(cls, obj) -> bool:
	"""
	Check chat is channel
	:param obj:
	:return:
	"""
	return cls._check(obj, [cls.CHANNEL])

[JrooTJunior]

But i think chat type filter can be also implemented (with deprecation of current filters)

For example implement next opportunity:

• @dp.message_handler(chat_type=types.ChatType.PRIVATE)
• @dp.message_handler(chat_type=[types.ChatType.GROUP, types.ChatType.SUPER_GROUP])

[JrooTJunior]

About text in list...
I see no prerequisites for implementing separated filter. Maybe it can be added to Text filter.

[riZZZhik]

• reply_to=id
• forward_from=id

[riZZZhik]

Maybe multiple all filters?

[JrooTJunior]

multiple all filters?

What do you mean?

[riZZZhik]

What do you mean?

optimize custom_filter return with Any()

[JrooTJunior]

optimize custom_filter return with Any()

I don't understand