Skip to content

Dispatcher polling task does not process cancellation #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
apatrushev opened this issue Aug 28, 2019 · 0 comments · Fixed by #201
Closed

Dispatcher polling task does not process cancellation #199

apatrushev opened this issue Aug 28, 2019 · 0 comments · Fixed by #201

Comments

@apatrushev
Copy link
Contributor

Context

Bare except hides CancelledError:

aiogram/aiogram/dispatcher/dispatcher.py

Lines 287 to 290 in 58a8f43

except:
log.exception('Cause exception while getting updates.')
await asyncio.sleep(error_sleep)
continue

Expected Behavior

Exit the loop on CancelledError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

process cancellation in dispatch polling
1 participant
@apatrushev