Skip to content

check_token bug report #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gabbhack opened this issue Nov 22, 2019 · 0 comments · Fixed by #240
Closed

check_token bug report #239

gabbhack opened this issue Nov 22, 2019 · 0 comments · Fixed by #240
Labels
bug Something is wrong with the framework
Milestone
2.5

Comments

@gabbhack
Copy link
Contributor

Context

from aiogram.bot.api import check_token

check_token('1234:') # True
check_token('12:ABC-DEF1234ghIkl-zyx57W2v1u123ew11') # ValidationError
  • aiogram version: 2.4

Expected Behavior

In the first case I expect an exception, in the second I expect True
Olegt0rr added a commit that referenced this issue Nov 23, 2019
@Olegt0rr
#239 added check for right part of token exists; removed check for le…
f5d0089 
…ft part length
Olegt0rr added a commit that referenced this issue Nov 23, 2019
@Olegt0rr
#239 added test cases for check_token
89b0754
@Olegt0rr Olegt0rr mentioned this issue Nov 23, 2019
Merged
2 tasks
Olegt0rr added a commit that referenced this issue Nov 23, 2019
@Olegt0rr
#239 added token type validation
4523a1c
@Olegt0rr Olegt0rr added the bug Something is wrong with the framework label Nov 24, 2019
@JrooTJunior JrooTJunior added this to the 2.5 milestone Nov 25, 2019
JrooTJunior added a commit that referenced this issue Nov 25, 2019
@JrooTJunior
Merge pull request #240 from aiogram/#239-check_token-bug-report
e4bf120 
#239 check_token fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is wrong with the framework
Projects
None yet
Milestone
2.5
Development

Successfully merging a pull request may close this issue.

#239 check_token fix aiogram/aiogram
3 participants
@JrooTJunior @Olegt0rr @gabbhack