Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text entities passed into sendMessage are not JSON-ised when POST-ing #457

Closed
sabbyX opened this issue Nov 8, 2020 · 5 comments
Closed
Labels
bug Something is wrong with the framework

Comments

@sabbyX
Copy link
Contributor

sabbyX commented Nov 8, 2020

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • Operating System: Windows 10 20H2
  • Python Version: 3.8.3
  • aiogram version: 2.11
  • aiohttp version:
  • uvloop version (if installed):

Expected Behavior

Please describe the behavior you are expecting

Current Behavior

What is the current behavior?

Failure Information (for bugs)

Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. step 1
  2. step 2
  3. you get it...

Failure Logs

Please include any relevant log snippets or files here.

@sabbyX
Copy link
Contributor Author

sabbyX commented Nov 8, 2020

image
This shows the value of field entities in FormData, yet BotAPI fail to apply the entity into text, no errors were thrown.

@JrooTJunior JrooTJunior added the bug Something is wrong with the framework label Nov 8, 2020
@JrooTJunior
Copy link
Member

Fixed in d0bfa8a
Will be released tomorrow.

@sabbyX
Copy link
Contributor Author

sabbyX commented Nov 9, 2020

Fixed in d0bfa8a
Will be released tomorrow.

Yeah, I tested it. look like aiogram is passing parse_mode field when entities are given (causes botAPI parse text based on parse mode instead). Should I create new issue?

@JrooTJunior
Copy link
Member

I see that when check previous problem but i don't think that is an bug.
But i think default parse mode logic should be changed...

Maybe it makes sense to backport sentinel parse mode from dev-3.x branch, where parse_mode=None can override globally configured parse mode.

Yep, please create an issue for this problem.
I think that will not be fixed in 2.11.1 version but soon

@JrooTJunior
Copy link
Member

Fixed in v2.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong with the framework
Projects
None yet
Development

No branches or pull requests

2 participants