Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spoiler formatting is not supported #865

Closed
tappress opened this issue Mar 20, 2022 · 2 comments · Fixed by #884
Closed

Spoiler formatting is not supported #865

tappress opened this issue Mar 20, 2022 · 2 comments · Fixed by #884
Assignees
Labels
3.x Issue or PR for stable 3.x version bug Something is wrong with the framework confirmed This issue is confirmed and requires action
Milestone

Comments

@tappress
Copy link

tappress commented Mar 20, 2022

def unparse(self, text: str, entities: Optional[List[MessageEntity]] = None) -> str:

Context

aiogram 3.x

Expected Behavior

Message.html_text and Message.md_text return fully unparsed raw representation of the formatted message text.

Current Behavior

Message.html_text and Message.md_text don't take in account spoiler entities. Spoiler entities are simply ignored.

@evgfilim1
Copy link
Contributor

Hello, @PrepWork.

Can you be more clear on this issue? Please, fill in the issue template below.

## Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

* Operating System:
* Python Version: 
* aiogram version: 
* aiohttp version: 
* uvloop version (if installed): 

## Expected Behavior

Please describe the behavior you are expecting

## Current Behavior

What is the current behavior?

## Failure Information (for bugs)

Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template.

### Steps to Reproduce

Please provide detailed steps for reproducing the issue.

1. step 1
2. step 2
3. you get it...

### Failure Logs

Please include any relevant log snippets or files here.

@evgfilim1 evgfilim1 added bug Something is wrong with the framework waiting for reply Further information is requested needs triage This issue is not yet confirmed labels Mar 21, 2022
@JrooTJunior JrooTJunior added confirmed This issue is confirmed and requires action and removed needs triage This issue is not yet confirmed labels Mar 27, 2022
@JrooTJunior
Copy link
Member

Thanks for information, will be fixed in Beta 3.

@JrooTJunior JrooTJunior added this to the 3.0 milestone Mar 27, 2022
@JrooTJunior JrooTJunior assigned JrooTJunior and unassigned tappress Mar 27, 2022
@evgfilim1 evgfilim1 removed the waiting for reply Further information is requested label Mar 29, 2022
@JrooTJunior JrooTJunior linked a pull request Apr 11, 2022 that will close this issue
10 tasks
@evgfilim1 evgfilim1 added the 3.x Issue or PR for stable 3.x version label Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version bug Something is wrong with the framework confirmed This issue is confirmed and requires action
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants