Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Restrict including routers with strings #896

Closed
MasterGroosha opened this issue Apr 25, 2022 · 0 comments · Fixed by #897
Closed

[3.x] Restrict including routers with strings #896

MasterGroosha opened this issue Apr 25, 2022 · 0 comments · Fixed by #897
Labels
3.x Issue or PR for stable 3.x version breaking This breaks backwards-compatibility enhancement Make it better!

Comments

@MasterGroosha
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently it is possible to include router using "module":"attrribute" string.
This leads to implicit imports and makes code less readable.

Describe the solution you'd like
Allow to only include routers by object

JrooTJunior added a commit that referenced this issue Apr 25, 2022
* #896 Restrict including routers with strings
* Remove imports util, bump dependencies
@JrooTJunior JrooTJunior linked a pull request Apr 25, 2022 that will close this issue
6 tasks
@evgfilim1 evgfilim1 added enhancement Make it better! breaking This breaks backwards-compatibility 3.x Issue or PR for stable 3.x version labels May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version breaking This breaks backwards-compatibility enhancement Make it better!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants