Skip to content

Add missing Message methods #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 21, 2022
Merged

Add missing Message methods #1030

merged 8 commits into from
Oct 21, 2022

Conversation

Danipulok
Copy link
Contributor

Add missing Message methods

Add following methods to Message:

Message.forward(...)
Message.edit_media(...)
Message.edit_live_location(...)
Message.stop_live_location(...)
Message.pin(...)
Message.unpin()

For each method add:

  • code
  • test
  • documentation

Type of change

  • New feature (non-breaking change that adds functionality)

How has this been tested?

Add new tests in tests/test_api/test_types/test_message.py

Test Configuration

Git hooks

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works as expected
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings or errors
  • My changes are compatible with minimum requirements of the project
  • I have made corresponding changes to the documentation

@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label Oct 18, 2022
@github-actions
Copy link

github-actions bot commented Oct 18, 2022

✔️ Changelog found.

Thank you for adding a description of the changes

@evgfilim1 evgfilim1 added the enhancement Make it better! label Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #1030 (a08b23f) into dev-3.x (f4d3dbf) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a08b23f differs from pull request most recent head a37919c. Consider uploading reports for the commit a37919c to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           dev-3.x     #1030     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          302       302             
  Lines         6949      8158   +1209     
===========================================
+ Hits          6949      8158   +1209     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiogram/types/message.py 100.00% <100.00%> (ø)
aiogram/types/chat.py 100.00% <0.00%> (ø)
aiogram/types/dice.py 100.00% <0.00%> (ø)
aiogram/types/file.py 100.00% <0.00%> (ø)
aiogram/types/game.py 100.00% <0.00%> (ø)
aiogram/types/poll.py 100.00% <0.00%> (ø)
aiogram/types/user.py 100.00% <0.00%> (ø)
aiogram/types/audio.py 100.00% <0.00%> (ø)
aiogram/types/venue.py 100.00% <0.00%> (ø)
aiogram/types/video.py 100.00% <0.00%> (ø)
... and 194 more

Co-authored-by: Alex Root Junior <jroot.junior@gmail.com>
@Danipulok
Copy link
Contributor Author

@JrooTJunior done

@JrooTJunior JrooTJunior merged commit 8b0ca52 into aiogram:dev-3.x Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version enhancement Make it better!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants