Skip to content

storage cleanup #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2023
Merged

storage cleanup #1144

merged 2 commits into from
Apr 8, 2023

Conversation

RootShinobi
Copy link
Contributor

Description

storage cleanup.

This change shouldn't affect you if you're writing bots, but if you're implementing a storage provider it might break your code.

Type of change

Please delete options that are not relevant.

  • Internal improvements
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label Mar 13, 2023
@github-actions
Copy link

github-actions bot commented Mar 13, 2023

✔️ Changelog found.

Thank you for adding a description of the changes

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #1144 (b177883) into dev-3.x (fea1b7b) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b177883 differs from pull request most recent head 373fade. Consider uploading reports for the commit 373fade to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x     #1144   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          354       354           
  Lines         8791      8791           
=========================================
  Hits          8791      8791           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiogram/fsm/context.py 100.00% <100.00%> (ø)
aiogram/fsm/middleware.py 100.00% <100.00%> (ø)
aiogram/fsm/storage/base.py 100.00% <100.00%> (ø)
aiogram/fsm/storage/memory.py 100.00% <100.00%> (ø)
aiogram/fsm/storage/redis.py 100.00% <100.00%> (ø)

@JrooTJunior JrooTJunior merged commit dbaf6fa into aiogram:dev-3.x Apr 8, 2023
JrooTJunior added a commit that referenced this pull request Apr 16, 2023
* Added missing FORUM_TOPIC_EDITED value to content_type property

* Added changelog to CHANGES

* Fixed aiogram/filters/magic_data.py:21:41: C416 Unnecessary `dict` comprehension (rewrite using `dict()`)

* Resolve  #1155: Different signature of startup/shutdown events on polling and webhooks  (#1156)

* Code refactor
- Use 'or' istead of 'A if A else B'
- Raise new error from catched error: raise Error from e

* Fixed signature of startup/shutdown events
- Include the **dispatcher.workflow_data as the handler arguments

* Update deep_linking basic examples (#1151)

* skip if current router does not have observer for custom event (#1147)

* skip if current router does not have observer for custom event

* Test custom event in router

* Feature changelog file

* fix style

* Change `InlineQueryResultType.MPEG` to more correct (#1146)

* Change `InlineQueryResultType.MPEG` to `InlineQueryResultType.MPEG4GIF`

* Change regexp for parse entities

* Use code generator to fix types

* Add changelog

* fix(docs): fix wrong page link in docs (#1154)

* storage cleanup (#1144)

* storage cleanup

* storage cleanup

* Update API docs

* Added tests

* Fix tests

---------

Co-authored-by: Alex Root Junior <jroot.junior@gmail.com>
Co-authored-by: Łukasz Tshipenchko <dev@zxc.sx>
Co-authored-by: Max Kotsiuruba <81016938+A5KET@users.noreply.github.com>
Co-authored-by: Andrey Tikhonov <andrey.tikhonov@quantori.com>
Co-authored-by: Desiders <47452083+Desiders@users.noreply.github.com>
Co-authored-by: Daniil <hum4noid@yandex.ru>
Co-authored-by: RootShinobi <111008396+RootShinobi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants